qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 08:54:45 -07:00
Code Releases Activity

cmd/internal/objabi: declare HeadType String on a non-pointer receiver

Browse Source 
objabi.HeadType is typically used as a non-pointer type, however the String function
is declared on a pointer receiver. This means that in most cases its integer value
is printed, rather than the value from the String function.

Change-Id: I3d28d9680e88a714bc1152ed5e1df4ac43d7a33f
Reviewed-on: https://go-review.googlesource.com/c/go/+/430556
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>
This commit is contained in:
Joel Sing 2022-09-13 19:32:34 +10:00 committed by Gopher Robot
parent 09f3ff174c
commit e084d84420
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/internal/objabi/head.go
View File

@ -80,8 +80,8 @@ func (h *HeadType) Set(s string) error {
return nil
}
func (h *HeadType) String() string {
switch *h {
func (h HeadType) String() string {
switch h {
case Haix:
return "aix"
case Hdarwin:
@ -105,5 +105,5 @@ func (h *HeadType) String() string {
case Hwindows:
return "windows"
}
return fmt.Sprintf("HeadType(%d)", *h)
return fmt.Sprintf("HeadType(%d)", h)
}