qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 17:16:54 -07:00
Code Releases Activity

runtime: replace --buildmode with -buildmode in tests

Browse Source 
While debugging issue #45638, I discovered that some tests were using
--buildmode command line parameter instead of -buildmode.

The --buildmode parameter is handled properly by the flag package - it
is read as -buildmode. But we should correct code anyway.

Updates #45638

Change-Id: I75cf95c7d11dcdf4aeccf568b2dea77bd8942352
Reviewed-on: https://go-review.googlesource.com/c/go/+/313351
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This commit is contained in:
Alex Brainman 2021-04-25 18:26:30 +10:00
parent ca8e8317be
commit e0815d041c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/runtime/signal_windows_test.go
View File

@ -32,7 +32,7 @@ func TestVectoredHandlerDontCrashOnLibrary(t *testing.T) {
// build go dll // build go dll
dll := filepath.Join(dir, "testwinlib.dll") dll := filepath.Join(dir, "testwinlib.dll")
cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", dll, "--buildmode", "c-shared", "testdata/testwinlib/main.go") cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", dll, "-buildmode", "c-shared", "testdata/testwinlib/main.go")
out, err := testenv.CleanCmdEnv(cmd).CombinedOutput() out, err := testenv.CleanCmdEnv(cmd).CombinedOutput()
if err != nil { if err != nil {
t.Fatalf("failed to build go library: %s\n%s", err, out) t.Fatalf("failed to build go library: %s\n%s", err, out)
@ -156,7 +156,7 @@ func TestLibraryCtrlHandler(t *testing.T) {
// build go dll // build go dll
dll := filepath.Join(dir, "dummy.dll") dll := filepath.Join(dir, "dummy.dll")
cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", dll, "--buildmode", "c-shared", "testdata/testwinlibsignal/dummy.go") cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", dll, "-buildmode", "c-shared", "testdata/testwinlibsignal/dummy.go")
out, err := testenv.CleanCmdEnv(cmd).CombinedOutput() out, err := testenv.CleanCmdEnv(cmd).CombinedOutput()
if err != nil { if err != nil {
t.Fatalf("failed to build go library: %s\n%s", err, out) t.Fatalf("failed to build go library: %s\n%s", err, out)