mirror of
https://github.com/golang/go
synced 2024-11-25 19:37:58 -07:00
[dev.link] all: clean up some TODOs
Change-Id: Iae1ca888729014b6fec97d7bd7ae082dbceb9fe5 Reviewed-on: https://go-review.googlesource.com/c/go/+/204837 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
This commit is contained in:
parent
5aea597905
commit
dfd8de1004
@ -33,7 +33,7 @@ import (
|
||||
// Autolib [...]stringOff // imported packages (for file loading) // TODO: add fingerprints
|
||||
// PkgIndex [...]stringOff // referenced packages by index
|
||||
//
|
||||
// DwarfFiles [...]stringOff // XXX as a separate block for now
|
||||
// DwarfFiles [...]stringOff
|
||||
//
|
||||
// SymbolDefs [...]struct {
|
||||
// Name stringOff
|
||||
|
@ -21,7 +21,7 @@ func TestSizeof(t *testing.T) {
|
||||
_64bit uintptr // size on 64bit platforms
|
||||
}{
|
||||
{Addr{}, 32, 48},
|
||||
//{LSym{}, 56, 104}, // TODO: re-enable
|
||||
{LSym{}, 76, 128},
|
||||
{Prog{}, 132, 200},
|
||||
}
|
||||
|
||||
|
@ -32,8 +32,6 @@ func main() {
|
||||
|
||||
// Check non-string symbols are not overwritten.
|
||||
// This also make them used.
|
||||
// TODO: decide if we need to issue an error if -X
|
||||
// is applied to a non-string unreachable symbol.
|
||||
if b || x != 0 {
|
||||
panic("b or x overwritten")
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user