qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 21:47:59 -07:00
Code Releases Activity

[dev.link] all: clean up some TODOs

Browse Source 
Change-Id: Iae1ca888729014b6fec97d7bd7ae082dbceb9fe5
Reviewed-on: https://go-review.googlesource.com/c/go/+/204837
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
This commit is contained in:
Cherry Zhang 2019-11-01 15:15:58 -04:00
parent 5aea597905
commit dfd8de1004
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/internal/goobj2/objfile.go
View File

@ -33,7 +33,7 @@ import (
// Autolib [...]stringOff // imported packages (for file loading) // TODO: add fingerprints // Autolib [...]stringOff // imported packages (for file loading) // TODO: add fingerprints
// PkgIndex [...]stringOff // referenced packages by index // PkgIndex [...]stringOff // referenced packages by index
// //
// DwarfFiles [...]stringOff // XXX as a separate block for now // DwarfFiles [...]stringOff
// //
// SymbolDefs [...]struct { // SymbolDefs [...]struct {
// Name stringOff // Name stringOff

2
src/cmd/internal/obj/sizeof_test.go
View File

@ -21,7 +21,7 @@ func TestSizeof(t *testing.T) {
_64bit uintptr // size on 64bit platforms _64bit uintptr // size on 64bit platforms
}{ }{
{Addr{}, 32, 48}, {Addr{}, 32, 48},
//{LSym{}, 56, 104}, // TODO: re-enable {LSym{}, 76, 128},
{Prog{}, 132, 200}, {Prog{}, 132, 200},
} }

2
test/linkx.go
View File

@ -32,8 +32,6 @@ func main() {
// Check non-string symbols are not overwritten. // Check non-string symbols are not overwritten.
// This also make them used. // This also make them used.
// TODO: decide if we need to issue an error if -X
// is applied to a non-string unreachable symbol.
if b || x != 0 { if b || x != 0 {
panic("b or x overwritten") panic("b or x overwritten")
} }