From dedce99c06c85c25f5e999ee55691648486dd934 Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Sat, 27 Aug 2022 10:13:50 +0800 Subject: [PATCH] os: convert Process.isdone to atomic type Change-Id: Ia3213d22678be0d56bf4f34dfe458441f7f5da97 Reviewed-on: https://go-review.googlesource.com/c/go/+/426077 Run-TryBot: Michael Pratt Run-TryBot: Jenny Rakoczy Reviewed-by: Michael Pratt Reviewed-by: Jenny Rakoczy TryBot-Result: Gopher Robot Auto-Submit: Jenny Rakoczy --- src/os/exec.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/os/exec.go b/src/os/exec.go index 9eb3166ecb..d01ca592ba 100644 --- a/src/os/exec.go +++ b/src/os/exec.go @@ -21,7 +21,7 @@ var ErrProcessDone = errors.New("os: process already finished") type Process struct { Pid int handle uintptr // handle is accessed atomically on Windows - isdone uint32 // process has been successfully waited on, non zero if true + isdone atomic.Bool // process has been successfully waited on sigMu sync.RWMutex // avoid race between wait and signal } @@ -32,11 +32,11 @@ func newProcess(pid int, handle uintptr) *Process { } func (p *Process) setDone() { - atomic.StoreUint32(&p.isdone, 1) + p.isdone.Store(true) } func (p *Process) done() bool { - return atomic.LoadUint32(&p.isdone) > 0 + return p.isdone.Load() } // ProcAttr holds the attributes that will be applied to a new process