qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 05:07:59 -07:00
Code Releases Activity

cmd/compile/internal/staticinit: remove FIPS debugging

Browse Source 
This is panicking on the darwin-amd64-longtest builders.
Not sure why, but it was added only to get a stack trace
during debugging. If there's still a problem, we should let
it proceed and find the real problem.

The test that was failing - internal/coverage/cfile - passes
with this CL, even when I set GODEBUG=fips140=on,
so there's hope that it will fix the longtest builders.

Change-Id: I9b3e743effdddcc0a76895922f87631527781dff
Reviewed-on: https://go-review.googlesource.com/c/go/+/628375
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Russ Cox 2024-11-15 09:34:04 -05:00 committed by Gopher Robot
parent ad6bc88e07
commit dea12628e6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/compile/internal/staticinit/sched.go
View File

@ -767,9 +767,6 @@ var statuniqgen int // name generator for static temps
func StaticName(t *types.Type) *ir.Name { func StaticName(t *types.Type) *ir.Name {
// Don't use LookupNum; it interns the resulting string, but these are all unique. // Don't use LookupNum; it interns the resulting string, but these are all unique.
sym := typecheck.Lookup(fmt.Sprintf("%s%d", obj.StaticNamePrefix, statuniqgen)) sym := typecheck.Lookup(fmt.Sprintf("%s%d", obj.StaticNamePrefix, statuniqgen))
if sym.Name == ".stmp_0" && sym.Pkg.Path == "crypto/internal/fips/check" {
panic("bad")
}
statuniqgen++ statuniqgen++
n := ir.NewNameAt(base.Pos, sym, t) n := ir.NewNameAt(base.Pos, sym, t)