qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 22:00:09 -07:00
Code Releases Activity

misc/dashboard/builder: always do a native build

Browse Source 
https://golang.org/cl/8134043 disabled cgo when cross compiling, this means builders which compile for both amd64 and 386 will be compiling the latter with cgo disabled.

This proposal modifies the builder to mirror the dist tool by always doing a native build.

Tested on my darwin/amd64 builder and confirmed the result when building darwin/386 is a native 386 build with cgo enabled.

R=bradfitz, dsymonds, r, adg
CC=golang-dev
https://golang.org/cl/8842044
This commit is contained in:
Dave Cheney 2013-04-18 16:42:56 +10:00
parent b08a3164c0
commit de2fcae372
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
misc/dashboard/builder/main.go
View File

@ -33,8 +33,6 @@ const (
var extraEnv = []string{
"CC",
"GOARM",
"GOHOSTARCH",
"GOHOSTOS",
"PATH",
"TMPDIR",
"USER",
@ -409,7 +407,9 @@ func (b *Builder) envv() []string {
}
e := []string{
"GOOS=" + b.goos,
"GOHOSTOS=" + b.goos,
"GOARCH=" + b.goarch,
"GOHOSTARCH=" + b.goarch,
"GOROOT_FINAL=/usr/local/go",
}
for _, k := range extraEnv {
@ -424,7 +424,9 @@ func (b *Builder) envv() []string {
func (b *Builder) envvWindows() []string {
start := map[string]string{
"GOOS": b.goos,
"GOHOSTOS": b.goos,
"GOARCH": b.goarch,
"GOHOSTARCH": b.goarch,
"GOROOT_FINAL": `c:\go`,
"GOBUILDEXIT": "1", // exit all.bat with completion status.
}