qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 02:14:42 -07:00
Code Releases Activity

debug/dwarf: better stmt list attr checking in LineReader

Browse Source 
Check for insane statement list attribute values when
constructing LineReader's for a compilation unit.

Fixes #52354.

Change-Id: Icb5298db31f6c5fe34c44e0ed4fe277a7cd676b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/400255
Run-TryBot: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Than McIntosh 2022-04-14 11:14:36 -04:00 committed by Gopher Robot
parent 62b8ec744b
commit dd97871282
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/debug/dwarf/line.go
View File

@ -152,7 +152,7 @@ func (d *Data) LineReader(cu *Entry) (*LineReader, error) {
// cu has no line table.
return nil, nil
}
if off > int64(len(d.line)) {
if off < 0 || off > int64(len(d.line)) {
return nil, errors.New("AttrStmtList value out of range")
}
// AttrCompDir is optional if all file names are absolute. Use

29
src/debug/dwarf/line_test.go
View File

@ -389,3 +389,32 @@ func TestPathJoin(t *testing.T) {
}
}
}
func TestPathLineReaderMalformed(t *testing.T) {
// This test case drawn from issue #52354. What's happening
// here is that the stmtList attribute in the compilation
// unit is malformed (negative).
var aranges, frame, pubnames, ranges, str []byte
abbrev := []byte{0x10, 0x20, 0x20, 0x20, 0x21, 0x20, 0x10, 0x21, 0x61,
0x0, 0x0, 0xff, 0x20, 0xff, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20,
0x20, 0x20, 0x20, 0x20, 0x20, 0x20}
info := []byte{0x0, 0x0, 0x0, 0x9, 0x0, 0x2, 0x0, 0x0, 0x0, 0x0,
0x20, 0x10, 0x10}
line := []byte{0x20}
Data0, err := New(abbrev, aranges, frame, info, line, pubnames, ranges, str)
if err != nil {
t.Fatalf("error unexpected: %v", err)
}
Reader0 := Data0.Reader()
Entry0, err := Reader0.Next()
if err != nil {
t.Fatalf("error unexpected: %v", err)
}
LineReader0, err := Data0.LineReader(Entry0)
if err == nil {
t.Fatalf("expected error")
}
if LineReader0 != nil {
t.Fatalf("expected nil line reader")
}
}