From dca76387a03d76c7ad4a79783e9c37238168280e Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 25 Sep 2018 10:54:35 -0400 Subject: [PATCH] go/ssa/interp: skip failing test This test introduces noise when using 'go test all' or 'go test ./...' to test go/packages and the tools that depend on it. Since it has been broken for around a month, skip it indefinitely. Updates golang/go#27292 Change-Id: I796292310332712e14bc8a0b73e36a8ed6f8a73f Reviewed-on: https://go-review.googlesource.com/137315 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- go/ssa/interp/interp_test.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/go/ssa/interp/interp_test.go b/go/ssa/interp/interp_test.go index ce908b4366e..97650a4071d 100644 --- a/go/ssa/interp/interp_test.go +++ b/go/ssa/interp/interp_test.go @@ -103,8 +103,8 @@ var gorootTestTests = []string{ "floatcmp.go", "crlf.go", // doesn't actually assert anything (runoutput) // Slow tests follow. - "bom.go", // ~1.7s - "gc1.go", // ~1.7s + "bom.go", // ~1.7s + "gc1.go", // ~1.7s "cmplxdivide.go cmplxdivide1.go", // ~2.4s // Working, but not worth enabling: @@ -156,9 +156,7 @@ var testdataTests = []string{ type successPredicate func(exitcode int, output string) error func run(t *testing.T, dir, input string, success successPredicate) bool { - if testing.Short() { - t.Skip("test breaks regularly; skipping in short mode so a failure doesn't affect trybots or build.golang.org; golang.org/issue/27292") - } + t.Skip("golang.org/issue/27292") if runtime.GOOS == "darwin" { t.Skip("skipping on darwin until golang.org/issue/23166 is fixed") }