qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 10:17:57 -07:00
Code Releases Activity

cmd/compile/internal/ssa: intrinsify atomic.Xchg8 on amd64

Browse Source 
For #68578

Change-Id: Ia9580579bfc4709945bfcf6ec3803d5d11812187
Reviewed-on: https://go-review.googlesource.com/c/go/+/606901
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Rhys Hiltner 2024-08-19 13:58:42 -07:00 committed by Gopher Robot
parent 841bb62f19
commit dc8902f4eb
6 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cmd/compile/internal/ssa/_gen/AMD64.rules
View File

@ -563,6 +563,7 @@
(AtomicStorePtrNoWB ptr val mem) => (Select1 (XCHGQ <types.NewTuple(typ.BytePtr,types.TypeMem)> val ptr mem))
// Atomic exchanges.
(AtomicExchange8 ptr val mem) => (XCHGB val ptr mem)
(AtomicExchange32 ptr val mem) => (XCHGL val ptr mem)
(AtomicExchange64 ptr val mem) => (XCHGQ val ptr mem)

1
src/cmd/compile/internal/ssa/_gen/genericOps.go
View File

@ -604,6 +604,7 @@ var genericOps = []opData{
{name: "AtomicStorePtrNoWB", argLength: 3, typ: "Mem", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Returns memory.
{name: "AtomicStoreRel32", argLength: 3, typ: "Mem", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Lock release, returns memory.
{name: "AtomicStoreRel64", argLength: 3, typ: "Mem", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Lock release, returns memory.
{name: "AtomicExchange8", argLength: 3, typ: "(UInt8,Mem)", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Returns old contents of *arg0 and new memory.
{name: "AtomicExchange32", argLength: 3, typ: "(UInt32,Mem)", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Returns old contents of *arg0 and new memory.
{name: "AtomicExchange64", argLength: 3, typ: "(UInt64,Mem)", hasSideEffects: true}, // Store arg1 to *arg0. arg2=memory. Returns old contents of *arg0 and new memory.
{name: "AtomicAdd32", argLength: 3, typ: "(UInt32,Mem)", hasSideEffects: true}, // Do *arg0 += arg1. arg2=memory. Returns sum and new memory.

7
src/cmd/compile/internal/ssa/opGen.go
View File

@ -3249,6 +3249,7 @@ const (
OpAtomicStorePtrNoWB
OpAtomicStoreRel32
OpAtomicStoreRel64
OpAtomicExchange8
OpAtomicExchange32
OpAtomicExchange64
OpAtomicAdd32
@ -41142,6 +41143,12 @@ var opcodeTable = [...]opInfo{
hasSideEffects: true,
generic: true,
},
{
name: "AtomicExchange8",
argLen: 3,
hasSideEffects: true,
generic: true,
},
{
name: "AtomicExchange32",
argLen: 3,

17
src/cmd/compile/internal/ssa/rewriteAMD64.go
View File

@ -587,6 +587,8 @@ func rewriteValueAMD64(v *Value) bool {
return rewriteValueAMD64_OpAtomicExchange32(v)
case OpAtomicExchange64:
return rewriteValueAMD64_OpAtomicExchange64(v)
case OpAtomicExchange8:
return rewriteValueAMD64_OpAtomicExchange8(v)
case OpAtomicLoad32:
return rewriteValueAMD64_OpAtomicLoad32(v)
case OpAtomicLoad64:
@ -23990,6 +23992,21 @@ func rewriteValueAMD64_OpAtomicExchange64(v *Value) bool {
return true
}
}
func rewriteValueAMD64_OpAtomicExchange8(v *Value) bool {
v_2 := v.Args[2]
v_1 := v.Args[1]
v_0 := v.Args[0]
// match: (AtomicExchange8 ptr val mem)
// result: (XCHGB val ptr mem)
for {
ptr := v_0
val := v_1
mem := v_2
v.reset(OpAMD64XCHGB)
v.AddArg3(val, ptr, mem)
return true
}
}
func rewriteValueAMD64_OpAtomicLoad32(v *Value) bool {
v_1 := v.Args[1]
v_0 := v.Args[0]

7
src/cmd/compile/internal/ssagen/intrinsics.go
View File

@ -296,6 +296,13 @@ func initIntrinsics(cfg *intrinsicBuildConfig) {
},
sys.PPC64)
addF("internal/runtime/atomic", "Xchg8",
func(s *state, n *ir.CallExpr, args []*ssa.Value) *ssa.Value {
v := s.newValue3(ssa.OpAtomicExchange8, types.NewTuple(types.Types[types.TUINT8], types.TypeMem), args[0], args[1], s.mem())
s.vars[memVar] = s.newValue1(ssa.OpSelect1, types.TypeMem, v)
return s.newValue1(ssa.OpSelect0, types.Types[types.TUINT8], v)
},
sys.AMD64)
addF("internal/runtime/atomic", "Xchg",
func(s *state, n *ir.CallExpr, args []*ssa.Value) *ssa.Value {
v := s.newValue3(ssa.OpAtomicExchange32, types.NewTuple(types.Types[types.TUINT32], types.TypeMem), args[0], args[1], s.mem())

1
src/cmd/compile/internal/ssagen/intrinsics_test.go
View File

@ -84,6 +84,7 @@ var wantIntrinsics = map[testIntrinsicKey]struct{}{
{"amd64", "internal/runtime/atomic", "Xadduintptr"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchg"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchg64"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchg8"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchgint32"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchgint64"}: struct{}{},
{"amd64", "internal/runtime/atomic", "Xchguintptr"}: struct{}{},