qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 15:30:05 -07:00
Code Releases Activity

cmd/dist: skip API check on plan9 builders

Browse Source 
The plan9-arm builder has a very slow filesystem and frequently times
out on this test. The api check verifies the API for all supported
GOOS/GOARCH/CGO_ENABLED combination anyway, so if we skip it on one
builder (or even most builders) there should be no loss of coverage.

Updates #37951

Change-Id: I86a93df2ec60a6af6d942e3954eef09ce67bb39e
Reviewed-on: https://go-review.googlesource.com/c/go/+/225662
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Bryan C. Mills 2020-03-26 12:00:07 -04:00
parent 69d3a34b17
commit dbd22c7227
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/cmd/dist/test.go vendored
View File

@ -741,7 +741,12 @@ func (t *tester) registerTests() {
})
}
}
if goos != "android" && !t.iOS() && goos != "js" {
// Only run the API check on fast development platforms. Android, iOS, and JS
// are always cross-compiled, and the filesystems on our only plan9 builders
// are too slow to complete in a reasonable timeframe. Every platform checks
// the API on every GOOS/GOARCH/CGO_ENABLED combination anyway, so we really
// only need to run this check once anywhere to get adequate coverage.
if goos != "android" && !t.iOS() && goos != "js" && goos != "plan9" {
t.tests = append(t.tests, distTest{
name: "api",
heading: "API check",