qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 23:14:47 -07:00
Code Releases Activity

cmd/ld: record complete runtime-gdb.py path again

Browse Source 
This code never got updated after the liblink shuffle.
Tested by hand that it works and respects GOROOT_FINAL.

The discussion in issue 6963 suggests that perhaps we should
just drop runtime-gdb.py entirely, but I am not convinced
that is true. It was in Go 1.2 and I don't see a reason not to
keep it in Go 1.3. The fact that binaries have not been emitting
the reference was just a missed detail in the liblink conversion,
not part of a grand plan.

Fixes #7506.
Fixes #6963.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews, iant, r
https://golang.org/cl/87870048
This commit is contained in:
Russ Cox 2014-04-15 21:17:18 -04:00
parent e97b3ab1f9
commit dacc020c00
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/cmd/ld/dwarf.c
View File

@ -1393,26 +1393,26 @@ movetomodule(DWDie *parent)
die->link = parent->child;
}
// if the histfile stack contains ..../runtime/runtime_defs.go
// use that to set gdbscript
// If the pcln table contains runtime/zruntime_defs_*.go, use that to set gdbscript path.
static void
finddebugruntimepath(LSym *s)
{
USED(s);
int i;
char *p;
LSym *f;
/* TODO
int i, l;
char *c;
if(gdbscript[0] != '\0')
return;
for (i = 1; i < histfilesize; i++) {
if ((c = strstr(histfile[i], "runtime/zruntime_defs")) != nil) {
l = c - histfile[i];
memmove(gdbscript, histfile[i], l);
memmove(gdbscript + l, "runtime/runtime-gdb.py", strlen("runtime/runtime-gdb.py") + 1);
for(i=0; i<s->pcln->nfile; i++) {
f = s->pcln->file[i];
if((p = strstr(f->name, "runtime/string.goc")) != nil) {
*p = '\0';
snprint(gdbscript, sizeof gdbscript, "%sruntime/runtime-gdb.py", f->name);
*p = 'r';
break;
}
}
*/
}
/*