qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 06:00:11 -07:00
Code Releases Activity

undo CL 107320046 / 97cd07dcb9d8

Browse Source 
Breaks the build

««« original CL description
cmd/go: build test files containing non-runnable examples

Even if we can't run them, we should at least check that they compile.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/107320046
»»»

TBR=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/110140044
This commit is contained in:
Andrew Gerrand 2014-06-25 12:04:36 +10:00
parent 280eb703a2
commit da1c2b182a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/test.go
View File

@ -1177,12 +1177,12 @@ func (t *testFuncs) load(filename, pkg string, seen *bool) error {
ex := doc.Examples(f)
sort.Sort(byOrder(ex))
for _, e := range ex {
*seen = true // Build the file even if the example is not runnable.
if e.Output == "" && !e.EmptyOutput {
// Don't run examples with no output.
continue
}
t.Examples = append(t.Examples, testFunc{pkg, "Example" + e.Name, e.Output})
*seen = true
}
return nil
}