qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-12 03:00:22 -07:00
Code Releases Activity

test: chdir before running go tool, cleanup afterwards.

Browse Source 
issue9355 generated a file a.[568] in test/ directory and left it there.
For tests like these, it is best to chdir to a test specific directory
before generating any temporary files, since the tests are running
in parallel and might otherwise race with each other for the same files.

Change-Id: I58d96256d4d8ee3fda70d81077f19006064a7425
Reviewed-on: https://go-review.googlesource.com/3813
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Rahul Chaudhry 2015-02-03 12:41:52 -08:00 committed by Ian Lance Taylor
parent f5f00be2ec
commit d81cc374be
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/fixedbugs/issue9355.go
View File

@ -21,11 +21,14 @@ func main() {
return
}
a, err := build.ArchChar(runtime.GOARCH)
if err != nil {
fmt.Println("BUG:", err)
os.Exit(1)
}
out := run("go", "tool", a+"g", "-S", filepath.Join("fixedbugs", "issue9355.dir", "a.go"))
check(err)
err = os.Chdir(filepath.Join("fixedbugs", "issue9355.dir"))
check(err)
out := run("go", "tool", a+"g", "-S", "a.go")
os.Remove("a." + a)
// 6g/8g print the offset as dec, but 5g/9g print the offset as hex.
patterns := []string{
`rel 0\+\d t=1 \"\"\.x\+8\r?\n`, // y = &x.b
@ -50,3 +53,10 @@ func run(cmd string, args ...string) []byte {
}
return out
}
func check(err error) {
if err != nil {
fmt.Println("BUG:", err)
os.Exit(1)
}
}