qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 16:57:58 -07:00
Code Releases Activity

cmd/5l, cmd/6l, cmd/8l: fix segfault on reading LOCALS for a duplicate definition.

Browse Source 
Fixes #5105.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/7965043
This commit is contained in:
Rémy Oudompheng 2013-03-25 22:09:55 +01:00
parent 60a1f54d6b
commit d815a14718
6 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/5l/obj.c
View File

@ -608,11 +608,15 @@ loop:
break;
case ALOCALS:
if(skip)
goto casedef;
cursym->locals = p->to.offset;
pc++;
break;
case ATYPE:
if(skip)
goto casedef;
pc++;
goto loop;

4
src/cmd/6l/obj.c
View File

@ -597,11 +597,15 @@ loop:
goto loop;
case ALOCALS:
if(skip)
goto casdef;
cursym->locals = p->to.offset;
pc++;
goto loop;
case ATYPE:
if(skip)
goto casdef;
pc++;
goto loop;

4
src/cmd/8l/obj.c
View File

@ -607,11 +607,15 @@ loop:
goto loop;
case ALOCALS:
if(skip)
goto casdef;
cursym->locals = p->to.offset;
pc++;
goto loop;
case ATYPE:
if(skip)
goto casdef;
pc++;
goto loop;

7
test/fixedbugs/issue5105.dir/a.go Normal file
View File

@ -0,0 +1,7 @@
// Copyright 2013 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package a
var A = [2]string{"hello", "world"}

15
test/fixedbugs/issue5105.dir/b.go Normal file
View File

@ -0,0 +1,15 @@
// Copyright 2013 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import "./a"
var B = [2]string{"world", "hello"}
func main() {
if a.A[0] != B[1] {
panic("bad hello")
}
}

10
test/fixedbugs/issue5105.go Normal file
View File

@ -0,0 +1,10 @@
// rundir
// Copyright 2013 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 5105: linker segfaults on duplicate definition
// of a type..hash.* function.
package ignored