From d6f2f833c93a41ec1c68e49804b8387a06b131c5 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 31 Oct 2019 20:13:50 +0000 Subject: [PATCH] strings: remove a redundant and flaky part of a test Fixes #35280 Change-Id: I6fa3747ff7b92c6fcabdf8692d85e103de55859f Reviewed-on: https://go-review.googlesource.com/c/go/+/204598 Run-TryBot: Brad Fitzpatrick Reviewed-by: Bryan C. Mills TryBot-Result: Gobot Gobot --- src/strings/builder_test.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/strings/builder_test.go b/src/strings/builder_test.go index 9e597015d88..b662efe7a57 100644 --- a/src/strings/builder_test.go +++ b/src/strings/builder_test.go @@ -178,21 +178,6 @@ func TestBuilderWriteByte(t *testing.T) { } func TestBuilderAllocs(t *testing.T) { - var b Builder - const msg = "hello" - b.Grow(len(msg) * 2) // because AllocsPerRun does an extra "warm-up" iteration - var s string - allocs := int(testing.AllocsPerRun(1, func() { - b.WriteString("hello") - s = b.String() - })) - if want := msg + msg; s != want { - t.Errorf("String: got %#q; want %#q", s, want) - } - if allocs > 0 { - t.Fatalf("got %d alloc(s); want 0", allocs) - } - // Issue 23382; verify that copyCheck doesn't force the // Builder to escape and be heap allocated. n := testing.AllocsPerRun(10000, func() {