qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 16:50:06 -07:00
Code Releases Activity

debug/gosym: run TestPCLine on Linux/AMD64 in short mode

Browse Source 
Currently TestPCLine is skipped in short mode. The test builds a
Linux/AMD64 binary, so it makes sense to skip it if we're cross
compiling, as building the runtime takes a while. But if we are
on Linux/AMD64, it will only build a small amount of code, which
isn't really slow. The test runs in 0.14 second on my machine.
I think it is acceptable to run in short mode. Then we'll have
trybot coverage for this test.

Change-Id: If682f88c28050f7daafde35b4f9e59c03b764a35
Reviewed-on: https://go-review.googlesource.com/c/go/+/353330
Trust: Cherry Mui <cherryyz@google.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
This commit is contained in:
Cherry Mui 2021-09-30 12:02:56 -04:00
parent b043d231fa
commit d4aed7e42c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/debug/gosym/pclntab_test.go
View File

@ -29,6 +29,10 @@ func dotest(t *testing.T) {
if runtime.GOARCH != "amd64" { if runtime.GOARCH != "amd64" {
t.Skipf("skipping on non-AMD64 system %s", runtime.GOARCH) t.Skipf("skipping on non-AMD64 system %s", runtime.GOARCH)
} }
// This test builds a Linux/AMD64 binary. Skipping in short mode if cross compiling.
if runtime.GOOS != "linux" && testing.Short() {
t.Skipf("skipping in short mode on non-Linux system %s", runtime.GOARCH)
}
var err error var err error
pclineTempDir, err = os.MkdirTemp("", "pclinetest") pclineTempDir, err = os.MkdirTemp("", "pclinetest")
if err != nil { if err != nil {
@ -198,9 +202,6 @@ func TestLineAline(t *testing.T) {
} }
func TestPCLine(t *testing.T) { func TestPCLine(t *testing.T) {
if testing.Short() {
t.Skip("skipping in -short mode")
}
dotest(t) dotest(t)
defer endtest() defer endtest()