qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 09:38:10 -07:00
Code Releases Activity

cmd/compile: eagerly CalcStructSize for synthetic ABI types

Browse Source 
The next CL is going to replace Type.Width with Type.Size(), but
Type.Size() isn't safe to call concurrently. So this CL calls
CalcStructSize, which *is* allowed to be used concurrently, but then
it's the caller's responsibility to ensure it's called right after
NewStruct.

Change-Id: If9cd81650ccb3a867b4449af757375fa56227901
Reviewed-on: https://go-review.googlesource.com/c/go/+/345483
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Matthew Dempsky 2021-08-26 16:57:06 -07:00
parent d7e2e2ec2b
commit d350a66532
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/compile/internal/abi/abiutils.go
View File

@ -722,14 +722,17 @@ func setup() {
types.NewField(nxp, fname("len"), ui), types.NewField(nxp, fname("len"), ui),
types.NewField(nxp, fname("cap"), ui), types.NewField(nxp, fname("cap"), ui),
}) })
types.CalcStructSize(synthSlice)
synthString = types.NewStruct(types.NoPkg, []*types.Field{ synthString = types.NewStruct(types.NoPkg, []*types.Field{
types.NewField(nxp, fname("data"), unsp), types.NewField(nxp, fname("data"), unsp),
types.NewField(nxp, fname("len"), ui), types.NewField(nxp, fname("len"), ui),
}) })
types.CalcStructSize(synthString)
synthIface = types.NewStruct(types.NoPkg, []*types.Field{ synthIface = types.NewStruct(types.NoPkg, []*types.Field{
types.NewField(nxp, fname("f1"), unsp), types.NewField(nxp, fname("f1"), unsp),
types.NewField(nxp, fname("f2"), unsp), types.NewField(nxp, fname("f2"), unsp),
}) })
types.CalcStructSize(synthIface)
}) })
} }