qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 20:01:19 -07:00
Code Releases Activity

go/types,cmd/compile/internal/types2: unskip std and cmd in TestStdlib

Browse Source 
CL 276272 accidentally skipped everything in TestStdlib while trying to
skip nested submodules of std and cmd.

For now, narrow the skip to just the problematic submodule rather than
trying to generalize. We can re-evaluate if it becomes a pattern to
vendor submodules in this way.

Fixes #46027

Change-Id: Ib355ff80dfbf17c3cf37d128a2f48d4216305267
Reviewed-on: https://go-review.googlesource.com/c/go/+/317869
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Rob Findley 2021-05-06 20:36:10 -04:00 committed by Robert Findley
parent 9524e93adf
commit d2b03111c4
2 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cmd/compile/internal/types2/stdlib_test.go
View File

@ -204,6 +204,9 @@ func TestStdKen(t *testing.T) {
// Package paths of excluded packages.
var excluded = map[string]bool{
"builtin": true,
// See #46027: some imports are missing for this submodule.
"crypto/ed25519/internal/edwards25519/field/_asm": true,
}
// typecheck typechecks the given package files.
@ -301,13 +304,6 @@ func (w *walker) walk(dir string) {
return
}
// skip submodules, which might not be vendored
for _, f := range files {
if f.Name() == "go.mod" {
return
}
}
// apply pkgh to the files in directory dir
// but ignore files directly under $GOROOT/src (might be temporary test files).
if dir != filepath.Join(runtime.GOROOT(), "src") {

10
src/go/types/stdlib_test.go
View File

@ -200,6 +200,9 @@ func TestStdKen(t *testing.T) {
// Package paths of excluded packages.
var excluded = map[string]bool{
"builtin": true,
// See #46027: some imports are missing for this submodule.
"crypto/ed25519/internal/edwards25519/field/_asm": true,
}
// typecheck typechecks the given package files.
@ -306,13 +309,6 @@ func (w *walker) walk(dir string) {
return
}
// skip submodules, which might not be vendored
for _, f := range files {
if f.Name() == "go.mod" {
return
}
}
// apply pkgh to the files in directory dir
// but ignore files directly under $GOROOT/src (might be temporary test files).
if dir != filepath.Join(runtime.GOROOT(), "src") {