qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
Code Releases Activity

internal/lsp/cmd: re-enable the definition cmd tests

Browse Source 
A lot has changed since golang/go#32794 was filed, and we now have many more
tests for the command line.

Fixes golang/go#32794

Change-Id: Ib268865a2345fd6676b2679bd76197c2d8658a85
Reviewed-on: https://go-review.googlesource.com/c/tools/+/204818
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
This commit is contained in:
Rebecca Stambler 2019-11-01 15:13:31 -04:00
parent 8dbcdeb83d
commit d229a6140f
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/lsp/cmd/test/definition.go
View File

@ -34,10 +34,6 @@ var godefModes = []godefMode{
}
func (r *runner) Definition(t *testing.T, spn span.Span, d tests.Definition) {
// TODO: https://golang.org/issue/32794.
if !*tests.UpdateGolden {
t.Skip()
}
if d.IsType || d.OnlyHover {
// TODO: support type definition, hover queries
return

2
internal/lsp/testdata/godef/b/b.go.golden vendored
View File

@ -57,7 +57,7 @@ foo/foo.go:1:1-30:16: defined here as myFoo "golang.org/x/tools/internal/lsp/foo
"end": {
"line": 30,
"column": 16,
"offset": 844
"offset": 922
}
},
"description": "myFoo \"golang.org/x/tools/internal/lsp/foo\" //@mark(myFoo, \"myFoo\"),godef(\"foo\", PackageFoo),godef(\"myFoo\", myFoo)"