qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 17:50:06 -07:00
Code Releases Activity

crypto/x509: improve internal comment

Browse Source 
Apply code review suggestion from CL 46715.

The block is doing more than just checking len(r.certs) == len(tc.cns).
It also verifies that certificate common names match.

Change-Id: I28d6926a5da48bd8f6c80aa5e5a1ed6d4990f845
Reviewed-on: https://go-review.googlesource.com/47132
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Dmitri Shuralyov 2017-06-29 00:38:38 -04:00 committed by Brad Fitzpatrick
parent dc86c9a6af
commit d13d6b3378
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/crypto/x509/root_unix_test.go
View File

@ -110,7 +110,7 @@ func TestEnvVars(t *testing.T) {
t.Fatal("nil roots") t.Fatal("nil roots")
} }
// Verify len(r.certs) == len(tc.cns), otherwise report where the mismatch is. // Verify that the returned certs match, otherwise report where the mismatch is.
for i, cn := range tc.cns { for i, cn := range tc.cns {
if i >= len(r.certs) { if i >= len(r.certs) {
t.Errorf("missing cert %v @ %v", cn, i) t.Errorf("missing cert %v @ %v", cn, i)