1
0
mirror of https://github.com/golang/go synced 2024-11-23 17:50:06 -07:00

testing: clarify that subtests are run as goroutines

Fixes #20394

Change-Id: Iabb2a53fd1ddb783e7fb5b60ced8482c2e2569c4
Reviewed-on: https://go-review.googlesource.com/44377
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Marcel van Lohuizen 2017-05-30 12:11:04 +02:00
parent 4c86f7bd49
commit d10549fb57

View File

@ -748,11 +748,12 @@ func tRunner(t *T, fn func(t *T)) {
t.finished = true
}
// Run runs f as a subtest of t called name. It reports whether f succeeded.
// Run will block until all its parallel subtests have completed.
// Run runs f as a subtest of t called name. It reports whether f succeeded. Run
// runs f in a separate goroutine and will block until all its parallel subtests
// have completed.
//
// Run may be called simultaneously from multiple goroutines, but all such
// calls must happen before the outer test function for t returns.
// Run may be called simultaneously from multiple goroutines, but all such calls
// must happen before the outer test function for t returns.
func (t *T) Run(name string, f func(t *T)) bool {
atomic.StoreInt32(&t.hasSub, 1)
testName, ok := t.context.match.fullName(&t.common, name)