qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-28 19:24:29 -06:00
Code Releases Activity

cmd/go: show full path name (testdata/script/foo.txt) in script errors

Browse Source 
Showing the full path (relative to the current directory)
instead of just foo.txt lets editors that understand file:line
jump straight to the file without having to edit it to say
testdata/script/ first.

Change-Id: I44177b687249f3c7c724b45d02f5167607369e1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/498119
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
This commit is contained in:
Russ Cox 2023-05-24 21:00:22 -04:00 committed by Gopher Robot
parent ee6b9dd47f
commit cfe8b43b1f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/go/script_test.go
View File

@ -151,7 +151,11 @@ func TestScript(t *testing.T) {
}
}
scripttest.Run(t, engine, s, filepath.Base(file), bytes.NewReader(a.Comment))
// Note: Do not use filepath.Base(file) here:
// editors that can jump to file:line references in the output
// will work better seeing the full path relative to cmd/go
// (where the "go test" command is usually run).
scripttest.Run(t, engine, s, file, bytes.NewReader(a.Comment))
})
}
}