1
0
mirror of https://github.com/golang/go synced 2024-11-23 00:30:07 -07:00

Update oudated comment

Update comment cause gc/select.go has been moved to walk/select.go and gc/reflect.go has been moved to reflectdata/reflect.go

Change-Id: I6894527e1e9dbca50ace92a51bf942f9495ce88c
GitHub-Last-Rev: 6d6a447144
GitHub-Pull-Request: golang/go#45976
Reviewed-on: https://go-review.googlesource.com/c/go/+/317191
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Michael Pratt <mpratt@google.com>
This commit is contained in:
makdon 2021-05-17 16:27:11 +00:00 committed by Keith Randall
parent 2ca44fe221
commit ce76298ee7
7 changed files with 16 additions and 16 deletions

View File

@ -669,7 +669,7 @@ var kinds = []int{
// tflag is documented in reflect/type.go. // tflag is documented in reflect/type.go.
// //
// tflag values must be kept in sync with copies in: // tflag values must be kept in sync with copies in:
// cmd/compile/internal/gc/reflect.go // cmd/compile/internal/reflectdata/reflect.go
// cmd/link/internal/ld/decodesym.go // cmd/link/internal/ld/decodesym.go
// reflect/type.go // reflect/type.go
// runtime/type.go // runtime/type.go

View File

@ -16,12 +16,12 @@ import (
// Decoding the type.* symbols. This has to be in sync with // Decoding the type.* symbols. This has to be in sync with
// ../../runtime/type.go, or more specifically, with what // ../../runtime/type.go, or more specifically, with what
// cmd/compile/internal/gc/reflect.go stuffs in these. // cmd/compile/internal/reflectdata/reflect.go stuffs in these.
// tflag is documented in reflect/type.go. // tflag is documented in reflect/type.go.
// //
// tflag values must be kept in sync with copies in: // tflag values must be kept in sync with copies in:
// cmd/compile/internal/gc/reflect.go // cmd/compile/internal/reflectdata/reflect.go
// cmd/link/internal/ld/decodesym.go // cmd/link/internal/ld/decodesym.go
// reflect/type.go // reflect/type.go
// runtime/type.go // runtime/type.go

View File

@ -68,7 +68,7 @@ type Type interface {
} }
/* /*
* These data structures are known to the compiler (../../cmd/internal/gc/reflect.go). * These data structures are known to the compiler (../../cmd/internal/reflectdata/reflect.go).
* A few are known to ../runtime/type.go to convey to debuggers. * A few are known to ../runtime/type.go to convey to debuggers.
* They are also known to ../runtime/type.go. * They are also known to ../runtime/type.go.
*/ */
@ -111,7 +111,7 @@ const (
// available in the memory directly following the rtype value. // available in the memory directly following the rtype value.
// //
// tflag values must be kept in sync with copies in: // tflag values must be kept in sync with copies in:
// cmd/compile/internal/gc/reflect.go // cmd/compile/internal/reflectdata/reflect.go
// cmd/link/internal/ld/decodesym.go // cmd/link/internal/ld/decodesym.go
// runtime/type.go // runtime/type.go
type tflag uint8 type tflag uint8

View File

@ -228,7 +228,7 @@ type Type interface {
// See https://golang.org/issue/4876 for more details. // See https://golang.org/issue/4876 for more details.
/* /*
* These data structures are known to the compiler (../../cmd/internal/gc/reflect.go). * These data structures are known to the compiler (../../cmd/internal/reflectdata/reflect.go).
* A few are known to ../runtime/type.go to convey to debuggers. * A few are known to ../runtime/type.go to convey to debuggers.
* They are also known to ../runtime/type.go. * They are also known to ../runtime/type.go.
*/ */
@ -271,7 +271,7 @@ const (
// available in the memory directly following the rtype value. // available in the memory directly following the rtype value.
// //
// tflag values must be kept in sync with copies in: // tflag values must be kept in sync with copies in:
// cmd/compile/internal/gc/reflect.go // cmd/compile/internal/reflectdata/reflect.go
// cmd/link/internal/ld/decodesym.go // cmd/link/internal/ld/decodesym.go
// runtime/type.go // runtime/type.go
type tflag uint8 type tflag uint8
@ -1910,7 +1910,7 @@ func MapOf(key, elem Type) Type {
// Make a map type. // Make a map type.
// Note: flag values must match those used in the TMAP case // Note: flag values must match those used in the TMAP case
// in ../cmd/compile/internal/gc/reflect.go:writeType. // in ../cmd/compile/internal/reflectdata/reflect.go:writeType.
var imap interface{} = (map[unsafe.Pointer]unsafe.Pointer)(nil) var imap interface{} = (map[unsafe.Pointer]unsafe.Pointer)(nil)
mt := **(**mapType)(unsafe.Pointer(&imap)) mt := **(**mapType)(unsafe.Pointer(&imap))
mt.str = resolveReflectName(newName(s, "", false)) mt.str = resolveReflectName(newName(s, "", false))
@ -2841,7 +2841,7 @@ func runtimeStructField(field StructField) (structField, string) {
// typeptrdata returns the length in bytes of the prefix of t // typeptrdata returns the length in bytes of the prefix of t
// containing pointer data. Anything after this offset is scalar data. // containing pointer data. Anything after this offset is scalar data.
// keep in sync with ../cmd/compile/internal/gc/reflect.go // keep in sync with ../cmd/compile/internal/reflectdata/reflect.go
func typeptrdata(t *rtype) uintptr { func typeptrdata(t *rtype) uintptr {
switch t.Kind() { switch t.Kind() {
case Struct: case Struct:
@ -2865,7 +2865,7 @@ func typeptrdata(t *rtype) uintptr {
} }
} }
// See cmd/compile/internal/gc/reflect.go for derivation of constant. // See cmd/compile/internal/reflectdata/reflect.go for derivation of constant.
const maxPtrmaskBytes = 2048 const maxPtrmaskBytes = 2048
// ArrayOf returns the array type with the given length and element type. // ArrayOf returns the array type with the given length and element type.

View File

@ -895,7 +895,7 @@ type funcinl struct {
// layout of Itab known to compilers // layout of Itab known to compilers
// allocated in non-garbage-collected memory // allocated in non-garbage-collected memory
// Needs to be in sync with // Needs to be in sync with
// ../cmd/compile/internal/gc/reflect.go:/^func.WriteTabs. // ../cmd/compile/internal/reflectdata/reflect.go:/^func.WriteTabs.
type itab struct { type itab struct {
inter *interfacetype inter *interfacetype
_type *_type _type *_type
@ -940,7 +940,7 @@ func extendRandom(r []byte, n int) {
// A _defer holds an entry on the list of deferred calls. // A _defer holds an entry on the list of deferred calls.
// If you add a field here, add code to clear it in freedefer and deferProcStack // If you add a field here, add code to clear it in freedefer and deferProcStack
// This struct must match the code in cmd/compile/internal/gc/reflect.go:deferstruct // This struct must match the code in cmd/compile/internal/reflectdata/reflect.go:deferstruct
// and cmd/compile/internal/gc/ssa.go:(*state).call. // and cmd/compile/internal/gc/ssa.go:(*state).call.
// Some defers will be allocated on the stack and some on the heap. // Some defers will be allocated on the stack and some on the heap.
// All defers are logically part of the stack, so write barriers to // All defers are logically part of the stack, so write barriers to

View File

@ -15,7 +15,7 @@ const debugSelect = false
// Select case descriptor. // Select case descriptor.
// Known to compiler. // Known to compiler.
// Changes here must also be made in src/cmd/internal/gc/select.go's scasetype. // Changes here must also be made in src/cmd/compile/internal/walk/select.go's scasetype.
type scase struct { type scase struct {
c *hchan // chan c *hchan // chan
elem unsafe.Pointer // data element elem unsafe.Pointer // data element

View File

@ -11,7 +11,7 @@ import "unsafe"
// tflag is documented in reflect/type.go. // tflag is documented in reflect/type.go.
// //
// tflag values must be kept in sync with copies in: // tflag values must be kept in sync with copies in:
// cmd/compile/internal/gc/reflect.go // cmd/compile/internal/reflectdata/reflect.go
// cmd/link/internal/ld/decodesym.go // cmd/link/internal/ld/decodesym.go
// reflect/type.go // reflect/type.go
// internal/reflectlite/type.go // internal/reflectlite/type.go
@ -25,7 +25,7 @@ const (
) )
// Needs to be in sync with ../cmd/link/internal/ld/decodesym.go:/^func.commonsize, // Needs to be in sync with ../cmd/link/internal/ld/decodesym.go:/^func.commonsize,
// ../cmd/compile/internal/gc/reflect.go:/^func.dcommontype and // ../cmd/compile/internal/reflectdata/reflect.go:/^func.dcommontype and
// ../reflect/type.go:/^type.rtype. // ../reflect/type.go:/^type.rtype.
// ../internal/reflectlite/type.go:/^type.rtype. // ../internal/reflectlite/type.go:/^type.rtype.
type _type struct { type _type struct {
@ -383,7 +383,7 @@ type maptype struct {
} }
// Note: flag values must match those used in the TMAP case // Note: flag values must match those used in the TMAP case
// in ../cmd/compile/internal/gc/reflect.go:writeType. // in ../cmd/compile/internal/reflectdata/reflect.go:writeType.
func (mt *maptype) indirectkey() bool { // store ptr to key instead of key itself func (mt *maptype) indirectkey() bool { // store ptr to key instead of key itself
return mt.flags&1 != 0 return mt.flags&1 != 0
} }