mirror of
https://github.com/golang/go
synced 2024-11-23 21:10:05 -07:00
http: add docs/warning on incorrect use of NewChunkedWriter
R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/4536075
This commit is contained in:
parent
12104807de
commit
ccafd53ed3
@ -6,14 +6,24 @@ package http
|
||||
|
||||
import (
|
||||
"io"
|
||||
"log"
|
||||
"os"
|
||||
"strconv"
|
||||
)
|
||||
|
||||
// NewChunkedWriter returns a new writer that translates writes into HTTP
|
||||
// "chunked" format before writing them to w. Closing the returned writer
|
||||
// "chunked" format before writing them to w. Closing the returned writer
|
||||
// sends the final 0-length chunk that marks the end of the stream.
|
||||
//
|
||||
// NewChunkedWriter is not needed by normal applications. The http
|
||||
// package adds chunking automatically if handlers don't set a
|
||||
// Content-Length header. Using NewChunkedWriter inside a handler
|
||||
// would result in double chunking or chunking with a Content-Length
|
||||
// length, both of which are wrong.
|
||||
func NewChunkedWriter(w io.Writer) io.WriteCloser {
|
||||
if _, bad := w.(*response); bad {
|
||||
log.Printf("warning: using NewChunkedWriter in an http.Handler; expect corrupt output")
|
||||
}
|
||||
return &chunkedWriter{w}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user