From cbd3305f8c7452963b7a1b4db001776b76370ae4 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 17 May 2023 15:59:47 -0400 Subject: [PATCH] cmd/cgo/internal/testnocgo: always run in default configuration This test is actually intended to test that we can build in -static mode even without any cgo. That means it's quite harmless to run in the default build configuration (in addition to running with various other build configurations). Change-Id: Ic6cb5c0eaab83f9bd5718aae57d0fdc69afcb8b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/496178 Reviewed-by: Bryan Mills Run-TryBot: Austin Clements TryBot-Result: Gopher Robot --- src/cmd/dist/test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 40df8c03b8f..2a3028aa7ec 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1130,6 +1130,7 @@ func (t *tester) registerCgoTests(heading string) { cgoTest("auto", "test", "auto", "") cgoTest("auto", "testtls", "auto", "") + cgoTest("auto", "testnocgo", "auto", "") // Stub out various buildmode=pie tests on alpine until 54354 resolved. builderName := os.Getenv("GO_BUILDER_NAME") @@ -1209,7 +1210,6 @@ func (t *tester) registerCgoTests(heading string) { // TODO(#56629): Why does this fail on netbsd-arm? cgoTest("static", "testtls", "external", "static", staticCheck) } - cgoTest("auto", "testnocgo", "auto", "", staticCheck) cgoTest("external", "testnocgo", "external", "", staticCheck) if goos != "android" { cgoTest("static", "testnocgo", "external", "static", staticCheck)