mirror of
https://github.com/golang/go
synced 2024-11-22 14:15:05 -07:00
cmd/compile: improve error message if init is directly invoked
Fixes #8481. Inform the user that init functions cannot be directly invoked in user code, as mandated by the spec at: http://golang.org/ref/spec#Program_initialization_and_execution. Change-Id: Ib12c0c08718ffd48b76b6f9b13c76bb6612d2e7b Reviewed-on: https://go-review.googlesource.com/34790 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
parent
dbd51ce99c
commit
cb6e0639fb
@ -3648,11 +3648,19 @@ func typecheckdef(n *Node) *Node {
|
||||
lineno = n.Pos
|
||||
}
|
||||
|
||||
// Note: adderrorname looks for this string and
|
||||
// adds context about the outer expression
|
||||
yyerror("undefined: %v", n.Sym)
|
||||
switch n.Sym.Name {
|
||||
case "init":
|
||||
// As per the spec at:
|
||||
// https://golang.org/ref/spec#Program_initialization_and_execution
|
||||
// init cannot be referred to in usercode.
|
||||
// See https://golang.org/issues/8481.
|
||||
yyerror("cannot refer to init functions")
|
||||
default:
|
||||
// Note: adderrorname looks for this string and
|
||||
// adds context about the outer expression
|
||||
yyerror("undefined: %v", n.Sym)
|
||||
}
|
||||
}
|
||||
|
||||
return n
|
||||
}
|
||||
|
||||
|
14
test/fixedbugs/issue8481.go
Normal file
14
test/fixedbugs/issue8481.go
Normal file
@ -0,0 +1,14 @@
|
||||
// errorcheck
|
||||
|
||||
// Copyright 2016 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package main
|
||||
|
||||
func init() {
|
||||
}
|
||||
|
||||
func main() {
|
||||
init() // ERROR "cannot refer to init functions"
|
||||
}
|
@ -15,7 +15,7 @@ func init() {
|
||||
}
|
||||
|
||||
func main() {
|
||||
init() // ERROR "undefined.*init"
|
||||
init() // ERROR "cannot refer to init functions"
|
||||
runtime.init() // ERROR "unexported.*runtime\.init"
|
||||
var _ = init // ERROR "undefined.*init"
|
||||
var _ = init // ERROR "cannot refer to init functions"
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user