mirror of
https://github.com/golang/go
synced 2024-11-23 19:30:05 -07:00
crypto/tls: reject ServerHellos with empty ALPN protocols.
https://tools.ietf.org/html/rfc7301#section-3.1 specifies that a ProtocolName may not be empty. This change enforces this for ServerHello messages—it's already enforced for ClientHello messages. Change-Id: Ic5a5be6bebf07fba90a3cabd10b07ab7b4337f53 Reviewed-on: https://go-review.googlesource.com/12003 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
parent
34695c4742
commit
cb5bca8e8a
@ -763,6 +763,10 @@ func (m *serverHelloMsg) unmarshal(data []byte) bool {
|
||||
return false
|
||||
}
|
||||
d = d[1:]
|
||||
if len(d) == 0 {
|
||||
// ALPN protocols must not be empty.
|
||||
return false
|
||||
}
|
||||
m.alpnProtocol = string(d)
|
||||
case extensionSCT:
|
||||
d := data[:length]
|
||||
|
Loading…
Reference in New Issue
Block a user