qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 23:58:02 -07:00
Code Releases Activity

go/ast: multiple "blank" imports are permitted

Browse Source 
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/6303099
This commit is contained in:
Robert Griesemer 2012-06-18 21:56:41 -07:00
parent 9c9754409d
commit ca2ae27dd0
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pkg/exp/types/check_test.go
View File

@ -203,7 +203,7 @@ func check(t *testing.T, testname string, testfiles []string) {
func TestCheck(t *testing.T) { func TestCheck(t *testing.T) {
// For easy debugging w/o changing the testing code, // For easy debugging w/o changing the testing code,
// if there is a local test file, only test that file. // if there is a local test file, only test that file.
const testfile = "test.go" const testfile = "testdata/test.go"
if fi, err := os.Stat(testfile); err == nil && !fi.IsDir() { if fi, err := os.Stat(testfile); err == nil && !fi.IsDir() {
fmt.Printf("WARNING: Testing only %s (remove it to run all tests)\n", testfile) fmt.Printf("WARNING: Testing only %s (remove it to run all tests)\n", testfile)
check(t, testfile, []string{testfile}) check(t, testfile, []string{testfile})

7
src/pkg/exp/types/testdata/test0.src vendored
View File

@ -6,7 +6,12 @@
package test0 package test0
import "unsafe" import (
"unsafe"
// we can have multiple blank imports (was bug)
_ "math"
_ "net/rpc"
)
const pi = 3.1415 const pi = 3.1415

2
src/pkg/go/ast/resolve.go
View File

@ -136,7 +136,7 @@ func NewPackage(fset *token.FileSet, files map[string]*File, importer Importer,
for _, obj := range pkg.Data.(*Scope).Objects { for _, obj := range pkg.Data.(*Scope).Objects {
p.declare(fileScope, pkgScope, obj) p.declare(fileScope, pkgScope, obj)
} }
} else { } else if name != "_" {
// declare imported package object in file scope // declare imported package object in file scope
// (do not re-use pkg in the file scope but create // (do not re-use pkg in the file scope but create
// a new object instead; the Decl field is different // a new object instead; the Decl field is different