qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 18:07:57 -07:00
Code Releases Activity

go/build: handle and warn of duplicate GOPATH entries

Browse Source 
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5519050
This commit is contained in:
Andrew Gerrand 2012-01-09 14:24:05 +11:00
parent 7478bb981a
commit c7e91724c0
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pkg/go/build/path.go
View File

@ -157,6 +157,7 @@ func init() {
Path = []*Tree{t} Path = []*Tree{t}
} }
Loop:
for _, p := range filepath.SplitList(os.Getenv("GOPATH")) { for _, p := range filepath.SplitList(os.Getenv("GOPATH")) {
if p == "" { if p == "" {
continue continue
@ -166,6 +167,21 @@ func init() {
log.Printf("invalid GOPATH %q: %v", p, err) log.Printf("invalid GOPATH %q: %v", p, err)
continue continue
} }
// Check for dupes.
// TODO(alexbrainman): make this correct under windows (case insensitive).
for _, t2 := range Path {
if t2.Path != t.Path {
continue
}
if t2.Goroot {
log.Printf("GOPATH is the same as GOROOT: %q", t.Path)
} else {
log.Printf("duplicate GOPATH entry: %q", t.Path)
}
continue Loop
}
Path = append(Path, t) Path = append(Path, t)
gcImportArgs = append(gcImportArgs, "-I", t.PkgDir()) gcImportArgs = append(gcImportArgs, "-I", t.PkgDir())
ldImportArgs = append(ldImportArgs, "-L", t.PkgDir()) ldImportArgs = append(ldImportArgs, "-L", t.PkgDir())