qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 13:25:15 -07:00
Code Releases Activity

[dev.unified] cmd/compile/internal/typecheck: replace unreachable code with assert

Browse Source 
Since the removal of -G=0 mode, IR is always well-typed. And in
well-typed IR, convlit will always returns expressions having real
types (i.e., not untyped).

Change-Id: I1ac99a88c94777829852519347a716d19af7948c
Reviewed-on: https://go-review.googlesource.com/c/go/+/413363
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Matthew Dempsky 2022-06-21 05:22:00 -07:00
parent 20e1d5ac8c
commit c70e93ff3d
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/cmd/compile/internal/typecheck/subr.go
View File

@ -301,24 +301,14 @@ func assignconvfn(n ir.Node, t *types.Type, context func() string) ir.Node {
n = convlit1(n, t, false, context) n = convlit1(n, t, false, context)
if n.Type() == nil { if n.Type() == nil {
return n base.Fatalf("cannot assign %v to %v", n, t)
}
if n.Type().IsUntyped() {
base.Fatalf("%L has untyped type", n)
} }
if t.Kind() == types.TBLANK { if t.Kind() == types.TBLANK {
return n return n
} }
// Convert ideal bool from comparison to plain bool
// if the next step is non-bool (like interface{}).
if n.Type() == types.UntypedBool && !t.IsBoolean() {
if n.Op() == ir.ONAME || n.Op() == ir.OLITERAL {
r := ir.NewConvExpr(base.Pos, ir.OCONVNOP, nil, n)
r.SetType(types.Types[types.TBOOL])
r.SetTypecheck(1)
r.SetImplicit(true)
n = r
}
}
if types.Identical(n.Type(), t) { if types.Identical(n.Type(), t) {
return n return n
} }