qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 23:17:57 -07:00
Code Releases Activity

cmd/internal/obj: symbol redeclared panics during InitTextSym

Browse Source 
Now the linker reports the following error message

/go/test/fixedbugs/issue68962.go:11:6: symbol main.c redeclared at
/go/test/fixedbugs/issue68962.go:13:6

Fixes #68962
This commit is contained in:
Yi Yang 2024-08-20 16:16:36 +08:00
parent 7fcd4a7007
commit c54ae7992d
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/internal/obj/plist.go
View File

@ -183,16 +183,16 @@ func (ctxt *Link) InitTextSym(s *LSym, flag int, start src.XPos) {
return return
} }
if s.Func() != nil { if s.Func() != nil {
ctxt.Diag("%s: symbol %s redeclared\n\t%s: other declaration of symbol %s", ctxt.PosTable.Pos(start), s.Name, ctxt.PosTable.Pos(s.Func().Text.Pos), s.Name) ctxt.Diag("symbol %s redeclared at %s", s.Name, ctxt.PosTable.Pos(start))
return return
} }
s.NewFuncInfo() s.NewFuncInfo()
if s.OnList() { if s.OnList() {
ctxt.Diag("%s: symbol %s redeclared", ctxt.PosTable.Pos(start), s.Name) ctxt.Diag("symbol %s redeclared at %s", s.Name, ctxt.PosTable.Pos(start))
return return
} }
if strings.HasPrefix(s.Name, `"".`) { if strings.HasPrefix(s.Name, `"".`) {
ctxt.Diag("%s: unqualified symbol name: %s", ctxt.PosTable.Pos(start), s.Name) ctxt.Diag("unqualified symbol name %s at %s", s.Name, ctxt.PosTable.Pos(start))
} }
// startLine should be the same line number that would be displayed via // startLine should be the same line number that would be displayed via

13
test/fixedbugs/issue68962.go Normal file
View File

@ -0,0 +1,13 @@
// compile
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import _ "unsafe"
//go:linkname a main.c
func a() {}
func c() {}