qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 00:04:41 -07:00
Code Releases Activity

sort: fix computation of maxDepth to avoid infinite loop

Browse Source 
The current computation loops indefinitely if n > 1<<30 (for 32-bit ints).

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5848067
This commit is contained in:
Stefan Nilsson 2012-03-20 14:23:12 -07:00 committed by Robert Griesemer
parent c5b45aa991
commit c5488d4f00
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkg/sort/sort.go
View File

@ -186,10 +186,10 @@ func quickSort(data Interface, a, b, maxDepth int) {
// Sort sorts data.
// The algorithm used is not guaranteed to be a stable sort.
func Sort(data Interface) {
// Switch to heapsort if depth of 2*ceil(lg(n)) is reached.
// Switch to heapsort if depth of 2*ceil(lg(n+1)) is reached.
n := data.Len()
maxDepth := 0
for 1<<uint(maxDepth) < n {
for i := n; i > 0; i >>= 1 {
maxDepth++
}
maxDepth *= 2