qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 21:14:44 -07:00
Code Releases Activity

go/ssa/interp: make os.Pipe intrinsic POSIX-portable; disable on Windows

Browse Source 
Change-Id: I6c2f495c7c75f86590a0d79f86423ca67d695347
Reviewed-on: https://go-review.googlesource.com/18325
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Alan Donovan 2016-01-06 14:05:03 -05:00
parent 0f870d4d86
commit c49318f04a
3 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
go/ssa/interp/external.go
View File

@ -237,21 +237,6 @@ func ext۰math۰Log(fr *frame, args []value) value {
return math.Log(args[0].(float64))
}
func ext۰os۰Pipe(fr *frame, args []value) value {
// This is an inlining of linux's os.Pipe.
// func os.Pipe() (r *File, w *File, err error)
var p [2]int
if err := syscall.Pipe2(p[:], syscall.O_CLOEXEC); err != nil {
// TODO(adonovan): fix: return an *os.SyscallError.
return tuple{nil, nil, wrapError(err)}
}
NewFile := fr.i.prog.ImportedPackage("os").Func("NewFile")
r := call(fr.i, fr, 0, NewFile, []value{uintptr(p[0]), "|0"})
w := call(fr.i, fr, 0, NewFile, []value{uintptr(p[1]), "|1"})
return tuple{r, w, wrapError(nil)}
}
func ext۰os۰runtime_args(fr *frame, args []value) value {
return fr.i.osArgs
}

16
go/ssa/interp/external_unix.go
View File

@ -8,6 +8,22 @@ package interp
import "syscall"
func ext۰os۰Pipe(fr *frame, args []value) value {
// func os.Pipe() (r *File, w *File, err error)
// The portable POSIX pipe(2) call is good enough for our needs.
var p [2]int
if err := syscall.Pipe(p[:]); err != nil {
// TODO(adonovan): fix: return an *os.SyscallError.
return tuple{nil, nil, wrapError(err)}
}
NewFile := fr.i.prog.ImportedPackage("os").Func("NewFile")
r := call(fr.i, fr, 0, NewFile, []value{uintptr(p[0]), "|0"})
w := call(fr.i, fr, 0, NewFile, []value{uintptr(p[1]), "|1"})
return tuple{r, w, wrapError(nil)}
}
func fillStat(st *syscall.Stat_t, stat structure) {
stat[0] = st.Dev
stat[1] = st.Ino

3
go/ssa/interp/external_windows.go
View File

@ -6,6 +6,9 @@ package interp
import "syscall"
func ext۰os۰Pipe(fr *frame, args []value) value {
panic("os.Pipe not yet implemented")
}
func ext۰syscall۰Close(fr *frame, args []value) value {
panic("syscall.Close not yet implemented")
}