mirror of
https://github.com/golang/go
synced 2024-11-12 08:10:21 -07:00
reflect: add comment about Type.Field allocation
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5586044
This commit is contained in:
parent
68aff958ae
commit
c4303aa59f
@ -789,6 +789,14 @@ func (t *structType) Field(i int) (f StructField) {
|
||||
f.Tag = StructTag(*p.tag)
|
||||
}
|
||||
f.Offset = p.offset
|
||||
|
||||
// NOTE(rsc): This is the only allocation in the interface
|
||||
// presented by a reflect.Type. It would be nice to avoid,
|
||||
// at least in the common cases, but we need to make sure
|
||||
// that misbehaving clients of reflect cannot affect other
|
||||
// uses of reflect. One possibility is CL 5371098, but we
|
||||
// postponed that ugliness until there is a demonstrated
|
||||
// need for the performance. This is issue 2320.
|
||||
f.Index = []int{i}
|
||||
return
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user