qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 10:54:40 -07:00
Code Releases Activity

os: deflake TestFdReadRace by increasing timeout

Browse Source 
This timeout will never be reached if the test passes, so it doesn't
much matter how long it is. The test is t.Parallel so on a slow system
1 second may occasionally not be enough, although on my laptop the
test takes about 0.02 seconds.

Fixes #34431

Change-Id: Ia2184e6be3747933bfe83aa6c8e1f77e6b1e0bba
Reviewed-on: https://go-review.googlesource.com/c/go/+/200764
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Ian Lance Taylor 2019-10-11 11:39:30 -07:00
parent fd33b2c974
commit c1ccae4d14
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/os/pipe_test.go
View File

@ -428,7 +428,7 @@ func TestFdReadRace(t *testing.T) {
go func() { go func() {
defer wg.Done() defer wg.Done()
var buf [10]byte var buf [10]byte
r.SetReadDeadline(time.Now().Add(time.Second)) r.SetReadDeadline(time.Now().Add(time.Minute))
c <- true c <- true
if _, err := r.Read(buf[:]); os.IsTimeout(err) { if _, err := r.Read(buf[:]); os.IsTimeout(err) {
t.Error("read timed out") t.Error("read timed out")