From c161412db0d0912a7438a865c39bdd7edcd20ede Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Thu, 14 Feb 2019 16:06:32 +0000 Subject: [PATCH] go/analysis/singlechecker: use Stderr in flag.Usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was using a mix of stdout and stderr. Most users won't notice, but it's inconsistent for no apparent reason. In particular, I noticed as some of my tool execution tests started failing. Change-Id: I9afe5f5bed0a575d3ba20e8dc1cc593c35565cf9 Reviewed-on: https://go-review.googlesource.com/c/162717 Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot Reviewed-by: Alan Donovan --- go/analysis/singlechecker/singlechecker.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/go/analysis/singlechecker/singlechecker.go b/go/analysis/singlechecker/singlechecker.go index 5194183de7..bd207d0fd2 100644 --- a/go/analysis/singlechecker/singlechecker.go +++ b/go/analysis/singlechecker/singlechecker.go @@ -52,11 +52,11 @@ func Main(a *analysis.Analyzer) { flag.Usage = func() { paras := strings.Split(a.Doc, "\n\n") fmt.Fprintf(os.Stderr, "%s: %s\n\n", a.Name, paras[0]) - fmt.Printf("Usage: %s [-flag] [package]\n\n", a.Name) + fmt.Fprintf(os.Stderr, "Usage: %s [-flag] [package]\n\n", a.Name) if len(paras) > 1 { - fmt.Println(strings.Join(paras[1:], "\n\n")) + fmt.Fprintln(os.Stderr, strings.Join(paras[1:], "\n\n")) } - fmt.Println("\nFlags:") + fmt.Fprintf(os.Stderr, "\nFlags:") flag.PrintDefaults() }