qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 06:14:51 -07:00
Code Releases Activity

cmd/compile: disable instrumentation for no-race packages earlier

Browse Source 
Rather than checking for each function whether the package supports
instrumentation, check once up front.

Relatedly, tweak the logic for preventing inlining calls to runtime
functions from instrumented packages. Previously, we simply disallowed
inlining runtime functions altogether when instrumenting. With this
CL, it's only disallowed from packages that are actually being
instrumented. That is, now intra-runtime calls can be inlined.

Updates #19054.

Change-Id: I88c97b48bf70193a8a3ee18d952dcb26b0369d55
Reviewed-on: https://go-review.googlesource.com/102815
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Matthew Dempsky 2018-03-27 15:35:51 -07:00
parent 690324408f
commit c0841ecd87
3 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/cmd/compile/internal/gc/inl.go
View File

@ -138,17 +138,6 @@ func caninl(fn *Node) {
Fatalf("caninl on non-typechecked function %v", fn)
}
// Runtime package must not be instrumented.
// Instrument skips runtime package. However, some runtime code can be
// inlined into other packages and instrumented there. To avoid this,
// we disable inlining of runtime functions when instrumenting.
// The example that we observed is inlining of LockOSThread,
// which lead to false race reports on m contents.
if instrumenting && myimportpath == "runtime" {
reason = "instrumenting and is runtime function"
return
}
n := fn.Func.Nname
if n.Func.InlinabilityChecked() {
return
@ -783,6 +772,16 @@ func mkinlcall1(n, fn *Node) *Node {
return n
}
if instrumenting && isRuntimePkg(fn.Sym.Pkg) {
// Runtime package must not be instrumented.
// Instrument skips runtime package. However, some runtime code can be
// inlined into other packages and instrumented there. To avoid this,
// we disable inlining of runtime functions when instrumenting.
// The example that we observed is inlining of LockOSThread,
// which lead to false race reports on m contents.
return n
}
if Debug_typecheckinl == 0 {
typecheckinl(fn)
}

12
src/cmd/compile/internal/gc/main.go
View File

@ -290,17 +290,23 @@ func Main(archInit func(*Arch)) {
startProfile()
if flag_race && flag_msan {
log.Fatal("cannot use both -race and -msan")
}
if ispkgin(omit_pkgs) {
flag_race = false
flag_msan = false
}
if flag_race {
racepkg = types.NewPkg("runtime/race", "race")
}
if flag_msan {
msanpkg = types.NewPkg("runtime/msan", "msan")
}
if flag_race && flag_msan {
log.Fatal("cannot use both -race and -msan")
} else if flag_race || flag_msan {
if flag_race || flag_msan {
instrumenting = true
}
if compiling_runtime && Debug['N'] != 0 {
log.Fatal("cannot disable optimizations while compiling runtime")
}

2
src/cmd/compile/internal/gc/racewalk.go
View File

@ -52,7 +52,7 @@ func ispkgin(pkgs []string) bool {
}
func instrument(fn *Node) {
if ispkgin(omit_pkgs) || fn.Func.Pragma&Norace != 0 {
if fn.Func.Pragma&Norace != 0 {
return
}