qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-16 21:34:52 -07:00
Code Releases Activity

runtime: skip TestSegv failures with "morestack on g0" on darwin/amd64

Browse Source 
This failure mode has been present since at least 2020-06-08. We have
enough information to diagnose it, and further failures don't seem to
be adding any new information at this point: they can only add noise,
both on the Go project's builders and in users' own modules (for
example, when run as part of 'go test all').

For #39457

Change-Id: I2379631da0c8af69598fa61c0cc5ac0ea6ba8267
Reviewed-on: https://go-review.googlesource.com/c/go/+/382395
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Bryan C. Mills 2022-02-02 10:19:30 -05:00 committed by Bryan Mills
parent fa4d9b8e2b
commit bec8a108b3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/runtime/crash_cgo_test.go
View File

@ -596,6 +596,9 @@ func TestSegv(t *testing.T) {
t.Log(got) t.Log(got)
want := "SIGSEGV" want := "SIGSEGV"
if !strings.Contains(got, want) { if !strings.Contains(got, want) {
if runtime.GOOS == "darwin" && runtime.GOARCH == "amd64" && strings.Contains(got, "fatal: morestack on g0") {
testenv.SkipFlaky(t, 39457)
}
t.Errorf("did not see %q in output", want) t.Errorf("did not see %q in output", want)
} }