1
0
mirror of https://github.com/golang/go synced 2024-11-16 22:14:45 -07:00

internal/trace: add Go 1.19 test data

Update instructions to match what seems to be the historical practice:
to generate canned traces when a version is finalized, rather than
waiting until it is superseded.

Follow rename of trace-internal tests from "Span" to "Region". Update
the net/http test invocation to match the apparent intent and the actual
http_1_5_good behavior (about 7ms of total run time and trace file size
under 50kB).

Change-Id: Ifd4c85882159478852e0b8f0d771b6f16b8f3c1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/413776
Run-TryBot: Rhys Hiltner <rhys@justin.tv>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Rhys Hiltner 2022-06-23 09:43:47 -07:00
parent 6b6c64b1cc
commit bd4753905d
7 changed files with 5 additions and 5 deletions

View File

@ -13,8 +13,8 @@ if [ $# != 1 ]; then
exit 1 exit 1
fi fi
go test -run ClientServerParallel4 -trace "testdata/http_$1_good" net/http go test -run '^$' -bench ClientServerParallel4 -benchtime 10x -trace "testdata/http_$1_good" net/http
go test -run 'TraceStress$|TraceStressStartStop$|TestUserTaskSpan$' runtime/trace -savetraces go test -run 'TraceStress$|TraceStressStartStop$|TestUserTaskRegion$' runtime/trace -savetraces
mv ../../runtime/trace/TestTraceStress.trace "testdata/stress_$1_good" mv ../../runtime/trace/TestTraceStress.trace "testdata/stress_$1_good"
mv ../../runtime/trace/TestTraceStressStartStop.trace "testdata/stress_start_stop_$1_good" mv ../../runtime/trace/TestTraceStressStartStop.trace "testdata/stress_start_stop_$1_good"
mv ../../runtime/trace/TestUserTaskSpan.trace "testdata/user_task_span_$1_good" mv ../../runtime/trace/TestUserTaskRegion.trace "testdata/user_task_region_$1_good"

View File

@ -152,8 +152,8 @@ func readTrace(r io.Reader) (ver int, events []rawEvent, strings map[uint64]stri
} }
switch ver { switch ver {
case 1005, 1007, 1008, 1009, 1010, 1011, 1019: case 1005, 1007, 1008, 1009, 1010, 1011, 1019:
// Note: When adding a new version, add canned traces // Note: When adding a new version, confirm that canned traces from the
// from the old version to the test suite using mkcanned.bash. // old version are part of the test suite. Add them using mkcanned.bash.
break break
default: default:
err = fmt.Errorf("unsupported trace file version %v.%v (update Go toolchain) %v", ver/1000, ver%1000, ver) err = fmt.Errorf("unsupported trace file version %v.%v (update Go toolchain) %v", ver/1000, ver%1000, ver)

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.