qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 21:54:40 -07:00
Code Releases Activity

cmd/gc, runtime: correct a misnomer regarding dead value maps

Browse Source 
The funcdata symbol incorrectly named the dead value map the
dead pointer map.  The dead value map identifies all dead
values, including pointers and non-pointers, in a stack frame.
The purpose of this map is to allow the runtime to poison
locations of dead data to catch lost invariants.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/38670043
This commit is contained in:
Carl Shapiro 2013-12-09 14:45:10 -08:00
parent 9a53fb571d
commit bc9691c465
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/gc/pgen.c
View File

@ -159,7 +159,7 @@ compile(Node *fn)
// compile time. At present, the amount of additional RSS is // compile time. At present, the amount of additional RSS is
// substantial enough to affect our smallest build machines. // substantial enough to affect our smallest build machines.
if(0) if(0)
gcdead = makefuncdatasym("gcdead·%d", FUNCDATA_DeadPointerMaps); gcdead = makefuncdatasym("gcdead·%d", FUNCDATA_DeadValueMaps);
else else
gcdead = nil; gcdead = nil;

4
src/cmd/gc/plive.c
View File

@ -1477,9 +1477,11 @@ liveness(Node *fn, Prog *firstp, Sym *argssym, Sym *livesym, Sym *deadsym)
if(0) livenessprintcfg(lv); if(0) livenessprintcfg(lv);
livenessepilogue(lv); livenessepilogue(lv);
// Emit the map data structures // Emit the live pointer map data structures
twobitwritesymbol(lv->livepointers, livesym, nil); twobitwritesymbol(lv->livepointers, livesym, nil);
twobitwritesymbol(lv->argslivepointers, argssym, nil); twobitwritesymbol(lv->argslivepointers, argssym, nil);
// Optionally emit a dead value map data structure for locals.
if(deadsym != nil) if(deadsym != nil)
twobitwritesymbol(lv->deadvalues, deadsym, nil); twobitwritesymbol(lv->deadvalues, deadsym, nil);

2
src/pkg/runtime/funcdata.h
View File

@ -12,7 +12,7 @@
#define FUNCDATA_ArgsPointerMaps 2 /* garbage collector blocks */ #define FUNCDATA_ArgsPointerMaps 2 /* garbage collector blocks */
#define FUNCDATA_LocalsPointerMaps 3 #define FUNCDATA_LocalsPointerMaps 3
#define FUNCDATA_DeadPointerMaps 4 #define FUNCDATA_DeadValueMaps 4
// To be used in assembly. // To be used in assembly.
#define ARGSIZE(n) PCDATA $PCDATA_ArgSize, $n #define ARGSIZE(n) PCDATA $PCDATA_ArgSize, $n