qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 07:50:05 -07:00
Code Releases Activity

flag: Check for Set error

Browse Source 
Check for Set error when a boolean flag isn't explicitly given a value.

Fixes #9345

Change-Id: I97a1289f8cf27567d1a726ebe5ef167c800f357c
Reviewed-on: https://go-review.googlesource.com/1897
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
This commit is contained in:
Michalis Kargakis 2014-12-21 23:03:11 +01:00 committed by Rob Pike
parent e4c2229e4c
commit bc611a31a5
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flag/flag.go
View File

@ -767,7 +767,9 @@ func (f *FlagSet) parseOne() (bool, error) {
return false, f.failf("invalid boolean value %q for -%s: %v", value, name, err)
}
} else {
fv.Set("true")
if err := fv.Set("true"); err != nil {
return false, f.failf("invalid boolean flag %s: %v", name, err)
}
}
} else {
// It must have a value, which might be the next argument.