From bbf925aa56bd9b7dbd07ced8506cbdf725e146a6 Mon Sep 17 00:00:00 2001
From: Russ Cox <rsc@golang.org>
Date: Mon, 26 Jul 2010 17:33:50 -0700
Subject: [PATCH] codereview: avoid crash if no config

Fixes #959.

R=r
CC=golang-dev
https://golang.org/cl/1876045
---
 lib/codereview/codereview.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index baed951225..84fbee61fa 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1632,7 +1632,11 @@ def RietveldSetup(ui, repo):
 			if line.startswith('defaultcc: '):
 				defaultcc = SplitCommaSpace(line[10:])
 	except:
-		pass
+		# If there are no options, chances are good this is not
+		# a code review repository; stop now before we foul
+		# things up even worse.  Might also be that repo doesn't
+		# even have a root.  See issue 959.
+		return
 
 	try:
 		f = open(repo.root + '/CONTRIBUTORS', 'r')