qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 23:40:22 -07:00
Code Releases Activity

misc/dashboard/codereview: fix obo

Browse Source 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6443091
This commit is contained in:
Russ Cox 2012-08-08 11:04:57 +10:00 committed by David Symonds
parent 3601f27708
commit bacccefa8d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
misc/dashboard/codereview/dashboard/cl.go
View File

@ -148,7 +148,8 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
} }
u := user.Current(c) u := user.Current(c)
if _, ok := emailToPerson[u.Email]; !ok { person, ok := emailToPerson[u.Email]
if !ok {
http.Error(w, "Not allowed", http.StatusUnauthorized) http.Error(w, "Not allowed", http.StatusUnauthorized)
return return
} }
@ -159,8 +160,7 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
http.Error(w, "Bad CL", 400) http.Error(w, "Bad CL", 400)
return return
} }
person, ok := preferredEmail[rev] if _, ok := preferredEmail[rev]; !ok && rev != "" {
if !ok && rev != "" {
c.Errorf("Unknown reviewer %q", rev) c.Errorf("Unknown reviewer %q", rev)
http.Error(w, "Unknown reviewer", 400) http.Error(w, "Unknown reviewer", 400)
return return