qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 04:04:46 -07:00
Code Releases Activity

text/template: remove an incorrect comment and clarify docs for AddParseTree

Browse Source 
The comment "If the name is the name of this template, overwrite this template."
is incorrect and should be "is not" instead. This comment is no longer
required once the docs are updated to mention this behaviour instead.

Fixes #34695

Change-Id: I773495b2194d7bb7619b13c1a28cbc76e8f69aac
Reviewed-on: https://go-review.googlesource.com/c/go/+/199139
Reviewed-by: Rob Pike <r@golang.org>
This commit is contained in:
Oliver Powell 2019-10-05 13:05:56 +02:00 committed by Rob Pike
parent 001fe7f33f
commit ba4593ac47
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/text/template/template.go
View File

@ -119,12 +119,12 @@ func (t *Template) copy(c *common) *Template {
} }
} }
// AddParseTree adds parse tree for template with given name and associates it with t. // AddParseTree associates the argument parse tree with the template t, giving
// If the template does not already exist, it will create a new one. // it the specified name. If the template has not been defined, this tree becomes
// If the template does exist, it will be replaced. // its definition. If it has been defined and already has that name, the existing
// definition is replaced; otherwise a new template is created, defined, and returned.
func (t *Template) AddParseTree(name string, tree *parse.Tree) (*Template, error) { func (t *Template) AddParseTree(name string, tree *parse.Tree) (*Template, error) {
t.init() t.init()
// If the name is the name of this template, overwrite this template.
nt := t nt := t
if name != t.name { if name != t.name {
nt = t.New(name) nt = t.New(name)