From ba14974e070734b3eb1a2b58097675c13978c1af Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 13 Aug 2013 23:33:49 +0400 Subject: [PATCH] undo CL 12787044 / ed695cdf962b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The NetBSD and OpenBSD failures are apparently real, not due to the test bug fixed in 100b9fc0c46f. ««« original CL description runtime/pprof: test netbsd and openbsd again Maybe these will work now. R=golang-dev, dvyukov, bradfitz CC=golang-dev https://golang.org/cl/12787044 »»» R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12873043 --- src/pkg/runtime/pprof/pprof.go | 2 +- src/pkg/runtime/pprof/pprof_test.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pkg/runtime/pprof/pprof.go b/src/pkg/runtime/pprof/pprof.go index 358539a5d1c..e7eb66a5576 100644 --- a/src/pkg/runtime/pprof/pprof.go +++ b/src/pkg/runtime/pprof/pprof.go @@ -20,7 +20,7 @@ import ( "text/tabwriter" ) -// BUG(rsc): Profiles are incomplete and inaccuate on OS X. +// BUG(rsc): Profiles are incomplete and inaccuate on NetBSD, OpenBSD, and OS X. // See http://golang.org/issue/6047 for details. // A Profile is a collection of stack traces showing the call sequences diff --git a/src/pkg/runtime/pprof/pprof_test.go b/src/pkg/runtime/pprof/pprof_test.go index 64c55b05ee1..738e2c4ec4e 100644 --- a/src/pkg/runtime/pprof/pprof_test.go +++ b/src/pkg/runtime/pprof/pprof_test.go @@ -175,9 +175,9 @@ func TestCPUProfileWithFork(t *testing.T) { // Operating systems that are expected to fail the tests. See issue 6047. var badOS = map[string]bool{ - "darwin": true, - //"netbsd": true, - //"openbsd": true, + "darwin": true, + "netbsd": true, + "openbsd": true, } func TestBlockProfile(t *testing.T) {