qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 19:54:44 -07:00
Code Releases Activity

Revert "internal/lsp: modify check for a missing package"

Browse Source 
This reverts commit 55ee3a4131.

Reason for revert: <forgot to run trybots>

Change-Id: I6d0890e2514841244a2a1f8ca861107c5de1f8aa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/184040
Reviewed-by: Suzy Mueller <suzmue@golang.org>
This commit is contained in:
Rebecca Stambler 2019-06-27 17:24:40 +00:00
parent 55ee3a4131
commit ba023a1bc9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/lsp/cache/load.go vendored
View File

@ -118,8 +118,7 @@ func (v *view) checkMetadata(ctx context.Context, f *goFile) (map[packageID]*met
return nil, pkg.Errors, fmt.Errorf("package %s has errors, skipping type-checking", pkg.PkgPath)
}
for importPath, importPkg := range pkg.Imports {
// If we encounter a package we cannot import, mark it as missing.
if len(importPkg.CompiledGoFiles) == 0 {
if len(importPkg.Errors) > 0 {
if f.missingImports == nil {
f.missingImports = make(map[packagePath]struct{})
}