qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 08:34:44 -07:00
Code Releases Activity

cmd/link: remove outdated cast and comment

Browse Source 
This program is written in Go now.

Change-Id: Ieec21a1bcac7c7a59e88cd1e1359977659de1757
Reviewed-on: https://go-review.googlesource.com/28549
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
David Crawshaw 2016-09-06 12:33:36 -04:00
parent bea39e63ec
commit b926bf83b0
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cmd/link/internal/ld/data.go
View File

@ -586,13 +586,7 @@ func relocsym(ctxt *Link, s *Symbol) {
o += Symaddr(ctxt, r.Sym) o += Symaddr(ctxt, r.Sym)
} }
// NOTE: The (int32) cast on the next line works around a bug in Plan 9's 8c o += r.Add - (s.Value + int64(r.Off) + int64(r.Siz))
// compiler. The expression s->value + r->off + r->siz is int32 + int32 +
// uchar, and Plan 9 8c incorrectly treats the expression as type uint32
// instead of int32, causing incorrect values when sign extended for adding
// to o. The bug only occurs on Plan 9, because this C program is compiled by
// the standard host compiler (gcc on most other systems).
o += r.Add - (s.Value + int64(r.Off) + int64(int32(r.Siz)))
case obj.R_SIZE: case obj.R_SIZE:
o = r.Sym.Size + r.Add o = r.Sym.Size + r.Add