qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-12 09:50:21 -07:00
Code Releases Activity

liblink: more precise literal word comparison on arm

Browse Source 
There are fields in the Addr that do not matter for the
purpose of deciding that the same word is already
in the current literal pool. Copy only the fields that
do matter.

This came up when comparing against the Go version
because the way it is invoked doesn't copy a few fields
(like node) that are never directly used by liblink itself.

Also remove a stray print that is not well-defined in
the new liblink. (Cannot use %D outside of %P, because
%D needs the outer Prog*.)

LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/119000043
This commit is contained in:
Russ Cox 2014-07-23 10:17:59 -04:00
parent d4d50b5f01
commit b916dc1992
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/liblink/asm5.c
View File

@ -953,7 +953,11 @@ addpool(Link *ctxt, Prog *p, Addr *a)
switch(c) {
default:
t.to = *a;
t.to.offset = a->offset;
t.to.sym = a->sym;
t.to.type = a->type;
t.to.name = a->name;
if(ctxt->flag_shared && t.to.sym != nil)
t.pcrel = p;
break;
@ -1102,7 +1106,6 @@ aclass(Link *ctxt, Addr *a)
case D_STATIC:
if(a->sym == 0 || a->sym->name == 0) {
print("null sym external\n");
print("%D\n", a);
return C_GOK;
}
ctxt->instoffset = 0; // s.b. unused but just in case