mirror of
https://github.com/golang/go
synced 2024-11-17 06:04:47 -07:00
cmd/link: disable new testpoint on mips pending investigation
Skip TestMinusRSymsWithSameName testpoint on MIPS for the time being since it triggers failures on that arch. Will re-enable once the problems are fixed. Updates #35779. Change-Id: I3e6650158ab04a2be77e3db5a5194df3bbb0859e Reviewed-on: https://go-review.googlesource.com/c/go/+/208557 Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
parent
6f7b96f6cb
commit
b81dd1c0e7
@ -13,6 +13,7 @@ import (
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"runtime"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
@ -132,12 +133,18 @@ int Cfunc2() { return blah(); }
|
||||
// TestMinusRSymsWithSameName tests a corner case in the new
|
||||
// loader. Prior to the fix this failed with the error 'loadelf:
|
||||
// $WORK/b001/_pkg_.a(ldr.syso): duplicate symbol reference: blah in
|
||||
// both main(.text) and main(.text)'
|
||||
// both main(.text) and main(.text)'. See issue #35779.
|
||||
func TestMinusRSymsWithSameName(t *testing.T) {
|
||||
testenv.MustHaveGoBuild(t)
|
||||
testenv.MustHaveCGO(t)
|
||||
t.Parallel()
|
||||
|
||||
// Skip this test on MIPS for the time being since it seems to trigger
|
||||
// problems with unknown relocations.
|
||||
if strings.Contains(runtime.GOARCH, "mips") {
|
||||
testenv.SkipFlaky(t, 35779)
|
||||
}
|
||||
|
||||
dir, err := ioutil.TempDir("", "go-link-TestMinusRSymsWithSameName")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
@ -197,7 +204,6 @@ func TestMinusRSymsWithSameName(t *testing.T) {
|
||||
cmd := exec.Command(goTool, "build")
|
||||
cmd.Dir = dir
|
||||
cmd.Env = env
|
||||
t.Logf("%s build", goTool)
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Logf("%s", out)
|
||||
t.Fatal(err)
|
||||
|
Loading…
Reference in New Issue
Block a user